LOGIN / SIGN UP

#268 allow maximizing of client windows

Reported by: marin Assigned to: ioerror
Phase: release-0.1.13 Component: windowmanager
Type: enhancement Status: closed
Priority: 3: Medium
Watchers:

Description

Hi, this pertains to the patch from Florian H of Jan 2009.

The check in file src/Frame.cc, function Frame::setStateMaximized, that denies the maximizing of dialog window is still in effect.

I suggest commenting out of the checking code [approximately line 1387] since the vertical/horizontal maximizing of Open and Save dialogs in applications is of practical importance by allowing greater field of view for visual orientation.

The hardcoded check duplicates (and is also less flexible than) the same result which could be acquired through autoproperties: cfgDeny/DIALOG/Maximized[Vert|Horiz]

Best regards, Marin

2011-11-27

84marin
22:35:37

Thanks!

2011-11-25

19ioerror
22:08:45 changed from new to closed
22:08:45

I think I'll remove the check for 0.1.14.

2010-06-13

84marin
21:32:10

That's correct.

If statement in Frame.cc actually spans 3 lines because of code style, braces etc, but here you quoted it in one line and that's it!

I have compiled PekWM 0.12 with that 'if' statement commented out and it works.

Here's a link to original conversation between you and Florian H:

http://pekwm.org/projects/pekwm/mailing_lists/pekwm/mail?mail_id=867

2010-06-10

19ioerror
12:22:05

I don't know which patch you are referring to, but you suggest to remove the lines "if (_client->getTransientWindow()) { return; }". Is this correct?