LOGIN / SIGN UP

#252 Resize code should "consume" last ButtonRelease event.

Reported by: wallex Assigned to: ioerror
Phase: release-0.1.13 Component: windowmanager
Type: bug Status: closed
Priority: 3: Medium
Watchers:

Description

Function Frame::doResize(bool left, bool x, bool top, bool y) will invoke a XPutBackEvent() when it is done. My question is... why?

One arising problem is when you have a configuration set like this:

//Display root meny when clicking on the background

      ButtonRelease = "1" { Actions = "ShowMenu Root" }

If resizing is done also via button 1, eg:

      Motion = "1" { Threshold = "4"; Actions = "Resize" }

Then whenever you resize a window by dragging its border, the last ButtonRelease which stops the process will also be re-handled, thus invoking the menu after every resize (unless the cursor at the end happens to be in the client or in the border, which isn't very frequent).

What is the point of putting back the event in the queue? I thought it might be to let the client receive the buttonRelease event, but some testing reveals that the client won't even receive the buttonPress event when it has been grabbed by PekWM already (even if no Motion action is triggered).

So it should be safe to remove, non?

2011-10-07

16:12:18

Close from commit: 1f5fc922f29ea10e722a5babdabf20837450cfd1 by Andreas

16:12:18 changed from open to closed

2011-10-06

22:13:34

I think I reported this back when I was using still pekwm-0.1.12, this is one of those bug-reports (with fix included) that were forgotten for the 0.1.13 release. Could we please get this one in for the next release (whenever that happens)?

2010-03-24

23:54:58 changed from new to open
23:54:58

Good catch, thanks.