LOGIN / SIGN UP

#236 PekWM does not compile with libpng-1.4.0

Reported by: Kingdom of Fish Assigned to: ioerror
Phase: release-0.1.11 Component: theme
Type: bug Status: closed
Priority: 2: High
Watchers:

Attachments

Description

Make with png enabled results in this after upgrade from libpng-1.2 to libpng-1.4:

PImageLoaderPng.cc: In member function ‘virtual unsigned char* PImageLoaderPng::load(const std::string&, unsigned int&, unsigned int&, bool&, bool&)’: PImageLoaderPng.cc:111: error: ‘png_set_gray_1_2_4_to_8’ was not declared in this scope PImageLoaderPng.cc: In member function ‘bool PImageLoaderPng::checkSignature(FILE*)’: PImageLoaderPng.cc:182: error: ‘png_check_sig’ was not declared in this scope make[2]: *** [PImageLoaderPng.o] Error 1

2010-02-07

19ioerror
17:35:40 changed from open to closed
17:35:27

Thank you! It's applied and pushed.

2pekdon
14:47:22 attached 0001-PImageLoaderPng.cc.patch
14:47:22

Attached patch from ryuo which should make it compile both with 1.2 and 1.4.

14:45:25 to release-0.1.11
14:45:25 changed from new to open
14:45:25 to theme
14:45:25 changed from 1 to 2
14:45:25 changed from Claes Nästén to Andreas

2010-02-06

2pekdon
15:31:33

From the libpng CHANGES: 

 version 1.4.0beta1 [April 20, 2006]
  Enabled iTXt support (changes png_struct, thus requires so-number change).
  Cleaned up PNG_ASSEMBLER_CODE_SUPPORTED vs PNG_MMX_CODE_SUPPORTED
  Eliminated PNG_1_0_X and PNG_1_2_X macros.
  Removed deprecated functions png_read_init, png_write_init, png_info_init,
    png_permit_empty_plte, png_set_gray_1_2_4_to_8, png_check_sig, and
    removed the deprecated macro PNG_MAX_UINT.
  Moved "PNG_INTERNAL" parts of png.h and pngconf.h into pngintrn.h
  Removed many WIN32_WCE #ifdefs (Cosmin).
  Reduced dependency on C-runtime library when on Windows (Simon-Pierre)
  Replaced sprintf() with png_sprintf() (Simon-Pierre)

So, need to check out how it should be done in 1.4 and hopefully make it compatible with both 1.2 and 1.4.