LOGIN / SIGN UP

#186 pekwm_themeset.sh does not work with newer mktemp

Reported by: dmoerner Assigned to: pekdon
Phase: Component:
Type: enhancement Status: closed
Priority: 2: High
Watchers:

Description

Hi, some distributions (Debian at least) have switched to using mktemp from libc. This version of mktemp requires that it be called with at least six X's in the name of the tempfile.

http://www.aquaphoenix.com/ref/gnu_c_library/libc_168.html

This patch should fix the problem:

---

commit 2cfb36b0f1ec047d151bff26dfcd2c618e2e8248 Author: Daniel Moerner <dmoerner@gmail.com> Date: Mon May 25 21:18:38 2009 -0700

    Follow libc's specification of mktemp and call it with 6 or more X's.

diff --git a/data/scripts/pekwm_themeset.sh.in b/data/scripts/pekwm_themeset.sh. index 232d11e..4145ad1 100644 --- a/data/scripts/pekwm_themeset.sh.in +++ b/data/scripts/pekwm_themeset.sh.in @@ -46,7 +46,7 @@ else

 
         # Get temporary file, not all platforms have mktemp though
         if test -x "/bin/mktemp"; then

- tmp_file=$(mktemp -t pekwm_themeset.XXX) || exit 1; + tmp_file=$(mktemp -t pekwm_themeset.XXXXXX) || exit 1;

         else
             tmp_file="/tmp/pekwm_themeset.${USER}"
         fi

2009-05-29

11:36:57 changed from new to closed
11:36:48

Thank you, patch is applied.

2009-05-26

06:27:55

I forgot that I couldn't figure out how to not mangle patches here, you can fetch the patch:

http://alioth.debian.org/~dmoerner-guest/call-mktemp-with-proper-number-of-X.diff