Hi, the code for pekwm_themeset.sh.in has changed a bit from 0.1.9a to 0.1.10 (as I am sure you are well aware!) I apologize for the vague title of this Task report but it's really two issues with the same root.

index e191c0c..cc9339f 100644 --- a/data/scripts/pekwm_themeset.sh.in +++ b/data/scripts/pekwm_themeset.sh.in @@ -1,6 +1,6 @@

 #!<SH>
 #

-# Copyright © 2003-2008 the pekwm development team +# Copyright © 2003-2009 the pekwm development team

 #
 # Add this to your menu to use this script:
 #

@@ -23,13 +23,13 @@ if test -z "${2}"; then

     # Check that theme directory exists, if it does not exist create a
     # dummy entry that says the dir does not exist.
     if test -d "${theme_dir}"; then

- for path in $(find "${theme_dir}" -maxdepth 2 -type f -name theme); do - theme_path="$(dirname "${path}")" - theme_name="$(basename "${theme_path}")" - echo -e "Entry = \"${theme_name}\" { Actions = \"Exec ${0} ${1} ${t - done + ( cd ${theme_dir}; + for theme_name in *; do + theme_path="${theme_dir}/${theme_name}" + echo "Entry = \"${theme_name}\" { Actions = \"Exec ${0} ${1} ${them + done )

     else

- echo -e "Entry = "No such directory ${theme_dir}" { Actions = "NO" }" + echo "Entry = \"No such directory ${theme_dir}\" { Actions = \"None\" }

     fi

     echo "}"

Although this commit does make the "No such directory" error message properly appear, there are two problems:

1) .pekwm/themes is currently not a directory created on the first run of pekwm. This means that a fresh install always produces an ugly "No such directory ~/.pekwm" on the start. It would be nice to make the themes/ directory in .pekwm when the rest of the config files are installed on the first run.

2) The * expansion globbing doesn't work properly when the directory is empty--instead of expanding the * to nothing, it just passes "*" as the name of the theme. The easiest way to fix this is to use another test using "ls -A $DIR" to see if the directory is empty and then just falling through without error if it is empty.

Cheers, Daniel